Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stats and risk difference parameters to forest plot modules #1210

Merged
merged 8 commits into from
Aug 6, 2024
Merged

Add stats and risk difference parameters to forest plot modules #1210

merged 8 commits into from
Aug 6, 2024

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Aug 2, 2024

Pull Request

Fixes #1209

@edelarua edelarua added the sme label Aug 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024 •
edited
Loading

Unit Tests Summary

    1 files     70 suites   1h 6m 34s ⏱️
  724 tests   614 ✅ 110 💤 0 ❌
1 992 runs  1 767 ✅ 225 💤 0 ❌

Results for commit 0e4eeb4.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024 •
edited
Loading

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_mmrm 💚 $703.32$ $-5.57$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💚 $225.66$ $-4.75$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_tte 💚 $64.55$ $-2.76$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💚 $100.06$ $-1.12$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💚 $259.68$ $-1.40$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💔 $86.81$ $+3.09$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💔 $121.72$ $+1.38$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💔 $230.34$ $+4.61$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💔 $178.73$ $+4.56$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💔 $82.37$ $+1.12$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💔 $64.99$ $+1.58$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💚 $67.95$ $-3.46$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💚 $89.65$ $-1.52$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💚 $73.13$ $-1.15$ $0$ $0$ $0$ $0$
shinytest2-tm_t_coxreg 💚 $70.51$ $-1.79$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💚 $87.59$ $-1.31$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_patyear 💚 $48.58$ $-1.02$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💚 $74.72$ $-2.16$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💚 $124.13$ $-1.87$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💚 $77.83$ $-1.68$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💚 $87.09$ $-2.13$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💚 $76.69$ $-2.19$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💚 $55.62$ $-1.16$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_t_abnormality_by_worst_grade 💚 $11.68$ $-2.29$ e2e_tm_t_abnormality_by_worst_grade_Module_initializes_in_teal_without_errors_and_produces_table_output.
tm_g_forest_rsp 👶 $+0.02$ template_forest_rsp_works_with_risk_difference_column_added
tm_g_forest_tte 👶 $+0.02$ template_forest_tte_works_with_risk_difference_column_added

Results for commit eb83b40

♻️ This comment has been updated with latest results.

Melkiades
Melkiades approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Emily!! :))

@edelarua edelarua enabled auto-merge (squash) August 6, 2024 21:06
@edelarua edelarua merged commit c07c96f into main Aug 6, 2024
29 checks passed
@edelarua edelarua deleted the 1209_forest_riskdiff@1246_riskdiff_tab_bin_rsp@main branch August 6, 2024 22:08
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Melkiades Melkiades Melkiades approved these changes

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add stats and risk difference parameters to forest plot modules
2 participants
@edelarua @Melkiades